feat(biome_configuration): add helpers for parsing .editorconfig files #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
05-13-editorconfig_add_parsing
branch
from
5fa93ae
to
ceb3545
Compare
CodSpeed Performance ReportMerging #2852 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
05-13-editorconfig_add_parsing
branch
2 times, most recently
from
65e81cf
to
d700cf9
Compare
Conaclos
reviewed
May 14, 2024
dyc3
force-pushed
the
05-13-editorconfig_add_parsing
branch
from
d700cf9
to
d5096bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first in a series of PRs to add
.editorconfigsupport to biome. I'll be trying to keep these fairly small so they are easy to review.The goal of this PR is to introduce the necessary helpers to actually parse the settings, and convert them into their biome equivalents.
Related to: #1724
Test Plan
Added some unit tests
cargo test -p biome_configuration editorconfig