refactor(biome_fs): make BiomePath::extension_as_str not panic
#2838
+15
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
05-13-refactor_biome_fs_make_biomepath_extension_as_str_not_panic
branch
from
d6b55c6
to
99f9df9
Compare
Conaclos
approved these changes
May 13, 2024
|
Thanks! |
dyc3
deleted the
05-13-refactor_biome_fs_make_biomepath_extension_as_str_not_panic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's no reason to let this particular function panic. I encountered this behavior when working on #2823.
Test Plan
It compiles, and tests pass.