feat(biome_grit_formatter): initial infrastructure

[abidjappie]

Summary

Set up the basic infrastructure required for further work on #2476

Implementation

• Run just new-crate biome_grit_formatter
• Update Cargo.toml with relevant settings
• Update xtask/codegen/src/formatter
• Run just gen-formatter

Test Plan

Cross comparison with other Biome formatters.

[abidjappie]

The code generator created src/js, do we need to keep this or can it be removed?

[ematipico]

The code generator created src/js, do we need to keep this or can it be removed?

This isn't correct. You have to update the codegen here:

biome/xtask/codegen/src/formatter.rs

Lines 785 to 786 in 7095ed0

	// TODO: I will handle formatting in a follow-up PR.
	LanguageKind::Grit => NodeConcept::Auxiliary,

[ematipico]

It's possible you'll have to update this too:

biome/xtask/codegen/src/formatter.rs

Lines 553 to 559 in 7095ed0

	enum NodeDialect {
	Js,
	Ts,
	Jsx,
	Json,
	Css,
	}

[abidjappie]

@ematipico Thank you for the feedback, as always!

I think I understand it a bit better now, although I am still a bit unclear on how the GritQL nodes are best categorized. I'll re-iterate again soon.

[abidjappie]

I'm not sure if covering all of these should be in the scope of this PR. (From the original issue)

Configuration

We need to add GritQL as a language in the configuration format, and let it support the common options around indentation, line length and type of newlines.

• Add test suite
• Introduce a can_format_grit_yet flag into biome_service
• Comment placement
• Handle biome ignore: format suppression comments in appropriate places

Additionally, I noticed that #1207 also added some additions like:

• Readme
• Git related
• More...

[arendjr]

Great start!

[arendjr]

I would've used name == "CodeSnippet" here ;)

[arendjr]

I'm not sure if covering all of these should be in the scope of this PR

No, I think I'll just merge as is (if the remaining tests are green), and you can add options like this in follow-up PRs. That will allow us to iterate a bit faster, and you'll have to worry less about merge issues.

[arendjr]

There just seems to be an issue with an unused dependency still.

[codspeed-hq]

CodSpeed Performance Report

Merging #2837 will not alter performance

_{Comparing abidjappie:feat/gritql-basic-infrastructure (94b4e8f) with main (f847aff)}

Summary

✅ 97 untouched benchmarks