Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): add graphql parser #2836

Merged
merged 2 commits into from
May 13, 2024
Merged

feat(bench): add graphql parser #2836

merged 2 commits into from
May 13, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR adds benchmarks for the GraphQL parser

Test Plan

CI should pass, and we should see three new benchmarks added

@github-actions github-actions bot added the A-Tooling Area: internal tools label May 13, 2024
@@ -0,0 +1,3 @@
https://raw.githubusercontent.com/amplication/amplication/909a1a77cd52e7f362cb5e037b3928146cef2ae4/schema.graphql
https://raw.githubusercontent.com/dgraph-io/dgraph/2a3dacd849c912643949a5ae6d78258b6c8f71ab/graphql/e2e/normal/schema.graphql
https://raw.githubusercontent.com/superfly/flyctl/9255529e9f423e6aca6eba64457187b6aead53fa/gql/schema.graphql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is soo good!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! I also found the schema of GitHub APIs, but it's 1.1MB ... 😅 It can wait I suppose

Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

Copy link

codspeed-hq bot commented May 13, 2024

CodSpeed Performance Report

Merging #2836 will not alter performance

Comparing feat/graphql-analyzer (b25ab3d) with main (7095ed0)

Summary

✅ 97 untouched benchmarks

@ematipico ematipico merged commit eb42e97 into main May 13, 2024
2 checks passed
@ematipico ematipico deleted the feat/graphql-analyzer branch May 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants