refactor(biome_analyze): expose RuleMetadata via RuleContext
#2821
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
May 12, 2024
CodSpeed Performance ReportMerging #2821 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
05-12-refactor_biome_analyze_expose_rulemetadata_via_rulecontext_
branch
2 times, most recently
from
4fb026a
to
344bac4
Compare
dyc3
force-pushed
the
05-12-refactor_biome_analyze_expose_rulemetadata_via_rulecontext_
branch
from
344bac4
to
310c891
Compare
ematipico
approved these changes
May 15, 2024
dyc3
deleted the
05-12-refactor_biome_analyze_expose_rulemetadata_via_rulecontext_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes the Rule's metadata available via
RuleContext, as an alternative, more discoverable way to get the rule's metadata.closes #2798
Test Plan
It compiles.