refactor(biome_analyze): add RuleAction::new
#2820
Merged
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
ematipico
reviewed
May 12, 2024
CodSpeed Performance ReportMerging #2820 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
05-12-refactor_biome_analyze_add_ruleaction_new_
branch
from
f68d593
to
c673e9d
Compare
dyc3
force-pushed
the
05-12-refactor_biome_analyze_add_ruleaction_new_
branch
from
c673e9d
to
fc0dd8a
Compare
ematipico
approved these changes
May 13, 2024
crates/biome_analyze/src/rule.rs
Outdated
| pub fn new( | ||
| category: ActionCategory, | ||
| applicability: impl Into<Applicability>, | ||
| message: MarkupBuf, |
There was a problem hiding this comment.
I think this can be changed into message: Markup, so we can move the .to_owned() inside this function, the caller won't need to do it anymore
There was a problem hiding this comment.
Based on this SO answer I don't think impl ToOwned is the right way to go, at least for now. I think that would require significant changes to how Markup and MarkupBuf are implemented.
There was a problem hiding this comment.
Actually, we need impl biome_console::fmt::Display.
Then inside the new function, we call markup!().to_owned
dyc3
force-pushed
the
05-12-refactor_biome_analyze_add_ruleaction_new_
branch
from
fc0dd8a
to
679fea3
Compare
ematipico
reviewed
May 13, 2024
crates/biome_js_analyze/src/assists/correctness/organize_imports.rs
Outdated
Show resolved
Hide resolved
dyc3
force-pushed
the
05-12-refactor_biome_analyze_add_ruleaction_new_
branch
2 times, most recently
from
73c6cb1
to
8b0ee6a
Compare
dyc3
force-pushed
the
05-12-refactor_biome_analyze_add_ruleaction_new_
branch
2 times, most recently
from
3fe941a
to
f42b6ce
Compare
dyc3
force-pushed
the
05-12-refactor_biome_analyze_add_ruleaction_new_
branch
from
f42b6ce
to
40b9736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For #2799, we want to phase out the manual construction of the
RuleActionstruct to make theapplicabilityfield private.This is intensionally small to make it easy to review before I do a huge codemod to actually phase out the manual construction.
related to: #2799
Test Plan
It compiles.