refactor(biome_graphql_parser): use is_nth_at_* #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2795 will not alter performanceComparing Summary
|
vohoanglong0107
force-pushed
the
refactor-graphql-nth-at
branch
3 times, most recently
from
b9614bd
to
826223c
Compare
ematipico
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some parsing rule pre-conditions was difficult to understand because certain definitions optionally have a description located right before them. This PR refactors those precondition using th NthAt trait, making them easier to comprehend and also fixing a subtle bug where the parser failed to recognize an object attribute preceded by a description.
Test Plan
All tests should pass.