Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css_parser): resolve CSS parsing issues #2792

Merged
merged 3 commits into from
May 9, 2024
Merged

fix(css_parser): resolve CSS parsing issues #2792

merged 3 commits into from
May 9, 2024

Conversation

denbezrukov
Copy link
Contributor

@denbezrukov denbezrukov commented May 9, 2024 •
edited
Loading

Summary

Closes #2789

  • Correctly parse ratios, such as when encountering '2/span'.
  • Parse numbers that are missing a fractional part. 1.e20

Test Plan

cargo test

@denbezrukov
fix(css_parser): Resolve CSS parsing issues
02239f9 
- Correctly parse ratios, such as when encountering '2/span'.
- Parse numbers that are missing a fractional part.
@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter L-CSS Language: CSS labels May 9, 2024
@denbezrukov denbezrukov changed the title fix(css_parser): Resolve CSS parsing issues fix(css_parser): resolve CSS parsing issues May 9, 2024
@denbezrukov
fix(css_parser): Resolve CSS parsing issues
368f7d4 
- Correctly parse ratios, such as when encountering '2/span'.
- Parse numbers that are missing a fractional part.
@denbezrukov
Merge branch 'main' into fix/css-parser
bbd6e12
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 9, 2024

CodSpeed Performance Report

Merging #2792 will not alter performance

Comparing fix/css-parser (bbd6e12) with main (ee5b9ee)

Summary

✅ 97 untouched benchmarks

@denbezrukov denbezrukov merged commit 5088667 into main May 9, 2024
16 checks passed
@denbezrukov denbezrukov deleted the fix/css-parser branch May 9, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter A-Parser Area: parser L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 CSS parsing issues
3 participants
@denbezrukov @ematipico @Conaclos