Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove libs that panic #2791

Merged
merged 1 commit into from
May 9, 2024
+8 −5
Merged

chore: remove libs that panic #2791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions xtask/bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ biome_css_analyze = { workspace = true }
biome_css_formatter = { workspace = true }
biome_css_parser = { workspace = true }
biome_css_syntax = { workspace = true }
biome_diagnostics = { workspace = true }
biome_formatter = { workspace = true }
biome_js_analyze = { workspace = true }
biome_js_formatter = { workspace = true }
Expand Down
5 changes: 1 addition & 4 deletions xtask/bench/benches/analyzer-libs-css.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.css
https://cdn.jsdelivr.net/npm/[email protected]/dist/full.css
https://cdn.jsdelivr.net/npm/[email protected]/build/pure.css
https://raw.githubusercontent.com/Dogfalo/materialize/v1-dev/dist/css/materialize.css
https://raw.githubusercontent.com/jgthms/bulma/master/css/bulma.css
https://raw.githubusercontent.com/foundation/foundation-sites/develop/dist/css/foundation.css
https://raw.githubusercontent.com/Semantic-Org/Semantic-UI/master/dist/semantic.css
https://raw.githubusercontent.com/tachyons-css/tachyons/main/css/tachyons.css
https://raw.githubusercontent.com/tachyons-css/tachyons/main/css/tachyons.css
6 changes: 5 additions & 1 deletion xtask/bench/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ mod test_case;
use crate::language::FormatNode;
pub use crate::language::Parse;
pub use crate::test_case::TestCase;
use biome_diagnostics::{print_diagnostic_to_string, Error};
use biome_formatter::Printed;
use biome_rowan::NodeCache;
use criterion::measurement::WallTime;
Expand Down Expand Up @@ -37,7 +38,10 @@ pub fn bench_parser_group(group: &mut BenchmarkGroup<WallTime>, test_case: TestC
&code,
|b, _| {
b.iter(|| {
black_box(parse.parse());
let result = black_box(parse.parse());
for diagnostic in result.into_diagnostics() {
println!("{}", print_diagnostic_to_string(&Error::from(diagnostic)));
}
})
},
);
Expand Down
Loading