Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): set the right name for binary executable #278

Merged
merged 1 commit into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/@biomejs/backend-jsonrpc/src/command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ export function getCommand(): string | null {

const PLATFORMS: PlatformPaths = {
win32: {
x64: "@biomejs/cli-win32-x64/rome.exe",
arm64: "@biomejs/cli-win32-arm64/rome.exe",
x64: "@biomejs/cli-win32-x64/biome.exe",
arm64: "@biomejs/cli-win32-arm64/biome.exe",
},
darwin: {
x64: "@biomejs/cli-darwin-x64/rome",
arm64: "@biomejs/cli-darwin-arm64/rome",
x64: "@biomejs/cli-darwin-x64/biome",
arm64: "@biomejs/cli-darwin-arm64/biome",
},
linux: {
x64: "@biomejs/cli-linux-x64/rome",
arm64: "@biomejs/cli-linux-arm64/rome",
x64: "@biomejs/cli-linux-x64/biome",
arm64: "@biomejs/cli-linux-arm64/biome",
},
};

Expand Down
16 changes: 8 additions & 8 deletions packages/@biomejs/biome/scripts/postinstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@ const { platform, arch } = process;

const PLATFORMS = {
win32: {
x64: "@biomejs/cli-win32-x64/rome.exe",
arm64: "@biomejs/cli-win32-arm64/rome.exe",
x64: "@biomejs/cli-win32-x64/biome.exe",
arm64: "@biomejs/cli-win32-arm64/biome.exe",
},
darwin: {
x64: "@biomejs/cli-darwin-x64/rome",
arm64: "@biomejs/cli-darwin-arm64/rome",
x64: "@biomejs/cli-darwin-x64/biome",
arm64: "@biomejs/cli-darwin-arm64/biome",
},
linux: {
x64: "@biomejs/cli-linux-x64/rome",
arm64: "@biomejs/cli-linux-arm64/rome",
x64: "@biomejs/cli-linux-x64/biome",
arm64: "@biomejs/cli-linux-arm64/biome",
},
};

Expand All @@ -22,13 +22,13 @@ if (binName) {
binPath = require.resolve(binName);
} catch {
console.warn(
`The Biome CLI postinstall script failed to resolve the binary file "${binName}". Running Biome from the npm package will probably not work correctly.`,
`The Biome CLI postinstall script failed to resolve the binary file "${binName}". Running Biome from the npm package will probably not work correctly.`
);
}
} else {
console.warn(
"The Biome CLI package doesn't ship with prebuilt binaries for your platform yet. " +
"You can still use the CLI by cloning the biomejs/biome repo from GitHub, " +
"and follow the instructions there to build the CLI for your platform.",
"and follow the instructions there to build the CLI for your platform."
);
}