fix: resolve deadlocks by narrowing the scope of locks

[mechairoi]

Summary

Resolve deadlocks by narrowing the scope of locks.
This change could be related to Issue #306, but its relevance is not guaranteed.

syntax -> documents

biome/crates/biome_service/src/workspace/server.rs

Lines 211 to 218 in d74b584

	match self.syntax.entry(biome_path) {
	Entry::Occupied(entry) => Ok(entry.get().clone()),
	Entry::Vacant(entry) => {
	let biome_path = entry.key();
	let capabilities = self.get_file_capabilities(biome_path);
	let mut document = self
	.documents

documents -> syntax (will change)

biome/crates/biome_service/src/workspace/server.rs

Lines 551 to 560 in d74b584

	let mut document = self
	.documents
	.get_mut(&params.path)
	.ok_or_else(WorkspaceError::not_found)?;
	debug_assert!(params.version > document.version);
	document.version = params.version;
	document.content = params.content;
	self.syntax.remove(&params.path);

Test Plan

while true; do; (prepare many not formatted files) && RUST_BACKTRACE=1 biome format --write; done;

[ematipico]

Thank you for looking after this. When dealing with deadlocks, what I found useful and guaranteed, is the use of small functions that do a single operation over a lock, so we take advantage of the fact that the lock is released when the scope of the function terminates.

In this case, other than moving the order of the function, maybe we should create two new functions that add and remove a path to syntax. What do you think?

[mechairoi]

I agree that creating functions is a good idea. Additionally, your suggestion inspired me to think that introducing nested scopes could be beneficial as well. The following changes also worked on my machine.

--- a/crates/biome_service/src/workspace/server.rs
+++ b/crates/biome_service/src/workspace/server.rs
@@ -548,14 +548,16 @@ impl Workspace for WorkspaceServer {

     /// Change the content of an open file
     fn change_file(&self, params: ChangeFileParams) -> Result<(), WorkspaceError> {
-        let mut document = self
-            .documents
-            .get_mut(&params.path)
-            .ok_or_else(WorkspaceError::not_found)?;
+        {
+            let mut document = self
+                .documents
+                .get_mut(&params.path)
+                .ok_or_else(WorkspaceError::not_found)?;

-        debug_assert!(params.version > document.version);
-        document.version = params.version;
-        document.content = params.content;
+            debug_assert!(params.version > document.version);
+            document.version = params.version;
+            document.content = params.content;
+        }

         self.syntax.remove(&params.path);
         Ok(())