fix(format/js): fix arrow function type annotation inconsistency with prettier #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
CodSpeed Performance ReportMerging #2766 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
05-08-fix_format_js_fix_arrow_function_type_annotation_inconsistency_with_prettier
branch
from
675ae89
to
90e5428
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dyc3
force-pushed
the
05-08-fix_format_js_fix_arrow_function_type_annotation_inconsistency_with_prettier
branch
from
90e5428
to
689a6ee
Compare
ah-yu
reviewed
May 10, 2024
crates/biome_js_formatter/tests/specs/prettier/typescript/arrow/issue-2736.tsx
Outdated
Show resolved
Hide resolved
dyc3
force-pushed
the
05-08-fix_format_js_fix_arrow_function_type_annotation_inconsistency_with_prettier
branch
2 times, most recently
from
eedb263
to
61ad32e
Compare
ah-yu
reviewed
May 10, 2024
dyc3
force-pushed
the
05-08-fix_format_js_fix_arrow_function_type_annotation_inconsistency_with_prettier
branch
from
61ad32e
to
47785ba
Compare
ematipico
approved these changes
May 10, 2024
dyc3
deleted the
05-08-fix_format_js_fix_arrow_function_type_annotation_inconsistency_with_prettier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a minor output mismatch with prettier related to arrow functions.
fixes #2736
Test Plan
Prettier has this condition when determining layout:
https://github.com/prettier/prettier/blob/fde0b49d7866e203ca748c306808a87b7c15548f/src/language-js/print/assignment.js#L145
I've added some snapshot tests based on the the playgrounds in #2736, but I'm not sure if I did it right.
cargo test -p biome_js_formatter