Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_graphql_parser): parse input object definition #2761

Merged

Conversation

vohoanglong0107
Copy link
Contributor

Summary

Parse GraphQL Input Object definition (link). This is also a small case, as almost all parsing logic was implemented in a previous PR that focused on parsing Object definition.

Once this is complete, we only have directive definitions left as the last GraphQL definitions. After handling both, we could start parsing GraphQL type extensions.

Test Plan

All tests should pass

Copy link

codspeed-hq bot commented May 8, 2024

CodSpeed Performance Report

Merging #2761 will not alter performance

Comparing vohoanglong0107:feat-graphql-input-object-definition (88f9435) with main (ed7509c)

Summary

✅ 85 untouched benchmarks

@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review May 8, 2024 10:32
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there!! 💪

@ematipico ematipico merged commit b29ac6f into biomejs:main May 8, 2024
12 checks passed
@vohoanglong0107 vohoanglong0107 deleted the feat-graphql-input-object-definition branch May 8, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants