Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint/noUselessStringConcat): add missing fix_kind #2748

Merged
merged 1 commit into from
May 6, 2024
Merged

fix(lint/noUselessStringConcat): add missing fix_kind #2748

merged 1 commit into from
May 6, 2024

Conversation

michellocana
Copy link
Contributor

Summary

Add missing fix_kind property to noUselessStringConcat rule, as discussed here.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels May 6, 2024
@michellocana michellocana mentioned this pull request May 6, 2024
Merged
Sec-ant
Sec-ant approved these changes May 6, 2024
View reviewed changes
crates/biome_js_analyze/src/lint/nursery/no_useless_string_concat.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sec-ant Sec-ant merged commit c269016 into biomejs:main May 6, 2024
10 of 11 checks passed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 6, 2024

CodSpeed Performance Report

Merging #2748 will not alter performance

Comparing michellocana:fix/no-useless-string-concat (a8690f7) with main (62beb76)

Summary

✅ 85 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sec-ant Sec-ant Sec-ant approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michellocana @Sec-ant