Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.7.3 #2722

Merged
merged 1 commit into from
May 6, 2024
Merged

release: v1.7.3 #2722

merged 1 commit into from
May 6, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented May 5, 2024

Summary

This patch release comes with several bug fixes, notably #2659 which was reported multiple times: #2683, #2704, #2702, ...

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels May 5, 2024
@ematipico
Copy link
Member

Reminder to create a PR in the website too, to add the new schema

@Sec-ant
Copy link
Member

Sec-ant commented May 5, 2024

The codegen CI in the website repo is failing, I think we should fix that before the next release: https://github.com/biomejs/website/actions/workflows/pin-submodule-and-run-codegen.yaml

And I think we can create an issue automatically if the codegen CI fails. I can work on it if this is a nice to have.

Copy link

codspeed-hq bot commented May 5, 2024

CodSpeed Performance Report

Merging #2722 will not alter performance

Comparing releases/v1.7.3 (3c922d3) with main (9c4be6b)

Summary

✅ 85 untouched benchmarks

@ematipico
Copy link
Member

And I think we can create an issue automatically if the codegen CI fails. I can work on it if this is a nice to have.

That would be really helpful.

@Conaclos
Copy link
Member Author

Conaclos commented May 5, 2024

The codegen CI in the website repo is failing, I think we should fix that before the next release

I do not want to delay the release too much because it fixes an important regression.
Is this really necessary to wait this fix?

@ematipico
Copy link
Member

@Conaclos you don't need to delay the release. The CI is failing because of a new nursery rule, don't worry

@Sec-ant
Copy link
Member

Sec-ant commented May 6, 2024

I do not want to delay the release too much because it fixes an important regression.
Is this really necessary to wait this fix?

I created two PRs to fix them: biomejs/website#243 and #2735. So you don't need to wait.

They're merged now.

@Conaclos Conaclos merged commit b9f90b7 into main May 6, 2024
15 checks passed
@Conaclos Conaclos deleted the releases/v1.7.3 branch May 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
3 participants