Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parse object type definition #2690

Merged
merged 1 commit into from
May 3, 2024
Merged

feat: parse object type definition #2690

merged 1 commit into from
May 3, 2024

Conversation

vohoanglong0107
Copy link
Contributor

Summary

Parse GraphQL object type definition (link). I parse both the happy path and the error path in this PR.

Test Plan

All tests should pass

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 3, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2690 will not alter performance

Comparing vohoanglong0107:feat-graphql-parse-object-type-definition (2c15c3a) with main (6d264aa)

Summary

✅ 86 untouched benchmarks

@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review May 3, 2024 12:00
ematipico
ematipico approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can clearly see that you are getting the hang of it :)

@ematipico ematipico merged commit ba63df3 into biomejs:main May 3, 2024
12 checks passed
@vohoanglong0107 vohoanglong0107 deleted the feat-graphql-parse-object-type-definition branch May 3, 2024 22:57
@DeltaV93 DeltaV93 mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vohoanglong0107 @ematipico