-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): correctly lint HTML-ish piped from stdin #2686
Merged
ematipico
merged 12 commits into
biomejs:main
from
tasshi-me:fix/lint-html-ish-piped-from-stdin
May 4, 2024
Merged
fix(cli): correctly lint HTML-ish piped from stdin #2686
ematipico
merged 12 commits into
biomejs:main
from
tasshi-me:fix/lint-html-ish-piped-from-stdin
May 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasshi-me
changed the title
fix(biome_cli): correctly lint HTML-ish piped from stdin
fix(cli): correctly lint HTML-ish piped from stdin
May 2, 2024
1 task
ematipico
approved these changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will fix #2225 and might fix biomejs/biome-intellij#50
With this PR, the
format,
lint,
andcheck
commands with the--stdin-file-path
option will correctly output the result for HTML-ish (Astro/Svelte/Vue) files.Implementation
According to code of lint for file input, when the input is an Astro/Svelte/Vue file, the linted output must be merged with original input.
That process is missing from the code for stdin, so I added it in this PR.
I considered refactoring the process to be common between std_in.rs and process_file.rs, but I did not do it because I am not familiar with this repository's architecture, and the scope of impact would be larger.
Test Plan
I added some new test cases and new snapshots.
format
with--stdin-file-path
must finish successfullyformat --write
with--stdin-file-path
must finish successfullylint
with--stdin-file-path
must finish successfullylint --apply
with--stdin-file-path
must finish successfullylint --apply-unsafe
with--stdin-file-path
must finish successfullycheck
with--stdin-file-path
must finish successfullycheck --apply
with--stdin-file-path
must finish successfullycheck --apply-unsafe
with--stdin-file-path
must finish successfully