Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_graphql_parser): implement NthAt for GraphqlLexer #2677

Merged
merged 1 commit into from
May 2, 2024

Conversation

vohoanglong0107
Copy link
Contributor

Summary

By implementing NthAt for GraphqlLexer, we can utilize more sophisticated checks for Graphql parser

Test Plan

All tests should pass.

feat(biome_graphql_parser): implement NthAt for GraphqlLexer
Copy link

codspeed-hq bot commented May 2, 2024

CodSpeed Performance Report

Merging #2677 will not alter performance

Comparing vohoanglong0107:feat-graphql-nth-token (0637f7e) with main (5fda633)

Summary

✅ 88 untouched benchmarks

@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review May 2, 2024 04:55
Copy link
Contributor

@denbezrukov denbezrukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it,
I have an idea how to remove the duplication around nth logic🤔

@ematipico ematipico merged commit 1f891f5 into biomejs:main May 2, 2024
12 checks passed
@vohoanglong0107 vohoanglong0107 deleted the feat-graphql-nth-token branch May 2, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants