Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_graphql_parser): parse scalar type definition #2663

Conversation

vohoanglong0107
Copy link
Contributor

Summary

Parse GraphQL scalar type definition. This is a small case so I parse both the happy path and error path in this PR

Test Plan

All tests should pass

Copy link

codspeed-hq bot commented May 1, 2024

CodSpeed Performance Report

Merging #2663 will not alter performance

Comparing vohoanglong0107:feat-graphql-parse-scalar-type-definition (b95aa8e) with main (1f891f5)

Summary

✅ 88 untouched benchmarks

@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review May 1, 2024 11:32
@vohoanglong0107 vohoanglong0107 force-pushed the feat-graphql-parse-scalar-type-definition branch from abf5a03 to b95aa8e Compare May 2, 2024 14:18
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@arendjr arendjr merged commit 6d264aa into biomejs:main May 3, 2024
12 checks passed
@vohoanglong0107 vohoanglong0107 deleted the feat-graphql-parse-scalar-type-definition branch May 3, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants