fix(lint/noUndeclaredVariables): don't report variable-only/type-only exports #2648
+34
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2637
When the semantic model finds an export it issues two references: a value reference and a type reference.
Only one reference get resolved when the referenced entity is only a variable (value) or only a type.
The remaining reference is forwarded to the parent scope and eventually marked as unresolved.
This is an erroneous behavior for two reasons:
export
cannot export a variable/type declared in a parent scope.export
doesn't need to export both a variable and a type.When we discover an
export
that exports a type or a variable, we no longer forward and mark as unresolved the dual variable/type.Test Plan
I added a test.