Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use TriviaPiece factory functions in more places #2632

Merged

Conversation

minht11
Copy link
Contributor

@minht11 minht11 commented Apr 28, 2024

Summary

Replace instances of TriviaPiece::new(TriviaPieceKind::whitespace, 1) with TriviaPiece::whitespace(1).

Please feel free to close this PR if the changes like these are not warranted.

Test Plan

No functionality changes

@github-actions github-actions bot added A-Core Area: core A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 28, 2024
@minht11 minht11 force-pushed the refactor/use-trivia-factory-in-more-places branch from cadb20f to f49c4f5 Compare April 28, 2024 21:05
Copy link

codspeed-hq bot commented Apr 28, 2024

CodSpeed Performance Report

Merging #2632 will not alter performance

Comparing minht11:refactor/use-trivia-factory-in-more-places (f49c4f5) with main (1abda0c)

Summary

✅ 90 untouched benchmarks

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arendjr arendjr merged commit 2798754 into biomejs:main Apr 29, 2024
13 checks passed
@minht11 minht11 deleted the refactor/use-trivia-factory-in-more-places branch April 29, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Area: core A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants