Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update workflow deps and cancel jobs on PR update #261

Merged
merged 1 commit into from
Sep 13, 2023
Merged

ci: update workflow deps and cancel jobs on PR update #261

merged 1 commit into from
Sep 13, 2023

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Sep 12, 2023 •
edited
Loading

Summary

  • Upgrade action versions
  • remove settings set to their default
  • cancel current jobs when a PR is updated (hopefully freeing some runners)
  • deploy website only when the website folder is changed

Test Plan

CI

@Conaclos Conaclos temporarily deployed to Website deployment September 12, 2023 22:36 — with GitHub Actions Inactive
@Conaclos Conaclos requested a review from a team September 12, 2023 22:39
@Conaclos Conaclos force-pushed the conaclos/update-workflows branch 2 times, most recently from a9acc94 to 8819d8e Compare September 12, 2023 22:44
ematipico
ematipico reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

deploy website only when the website folder is changed

This is the only thing we should revert. The playground relies on biome_wasm, and we want to ship it every time there's a change.

@Conaclos Conaclos temporarily deployed to Website deployment September 13, 2023 09:46 — with GitHub Actions Inactive
@Conaclos Conaclos merged commit 7cdcf09 into main Sep 13, 2023
5 checks passed
@Conaclos Conaclos deleted the conaclos/update-workflows branch September 13, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conaclos @ematipico