Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(organizeImport): ignore side effect imports #2563

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Apr 22, 2024

Summary

Fix #817

Now every side effect import creates its own import group.

Test Plan

I added a test.

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Apr 22, 2024
@Conaclos Conaclos requested a review from a team April 22, 2024 17:25
Copy link

codspeed-hq bot commented Apr 22, 2024

CodSpeed Performance Report

Merging #2563 will improve performances by 7.27%

Comparing conaclos/817/ignore-side-effect-imports (3dbd546) with main (b150000)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/817/ignore-side-effect-imports Change
db.json[uncached] 86 ms 80.2 ms +7.27%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a very clever fix!

@Conaclos Conaclos merged commit 2ecfe4c into main Apr 22, 2024
16 checks passed
@Conaclos Conaclos deleted the conaclos/817/ignore-side-effect-imports branch April 22, 2024 21:40
@Conaclos Conaclos changed the title fix(organizeImport): ignorer side effect imports fix(organizeImport): ignore side effect imports Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Ignore side-effect imports when organising imports
3 participants