Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(xstask): remove deps fs_extra and filetime #2562

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Conaclos
Copy link
Member

Summary

  • Since Rust .75, standard functions are available to update file times making filetime` optional.

  • fs_extra can easily be replaced with the standard library

Test Plan

I manually tested the codegen.

@github-actions github-actions bot added the A-Tooling Area: internal tools label Apr 22, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@Conaclos Conaclos force-pushed the conaclos/remove-more-xtask-deps branch 2 times, most recently from ce85b56 to b9452eb Compare April 22, 2024 16:11
- Since Rust `.75, standard functions are available to update
  file times making `filetime` optional.
- `fs_extra` can easily be replaced with the standard library
Copy link

codspeed-hq bot commented Apr 22, 2024

CodSpeed Performance Report

Merging #2562 will improve performances by 6.21%

Comparing conaclos/remove-more-xtask-deps (b9452eb) with main (d6f1f2b)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/remove-more-xtask-deps Change
big5-added.json[uncached] 2.9 ms 2.7 ms +6.21%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best code is less code!

@Conaclos Conaclos merged commit b150000 into main Apr 22, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/remove-more-xtask-deps branch April 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants