Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_js_analyze): useArrayLiterals #2541

Merged

Conversation

Kazuhiro-Mimaki
Copy link
Contributor

@Kazuhiro-Mimaki Kazuhiro-Mimaki commented Apr 21, 2024

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Apr 21, 2024
@Kazuhiro-Mimaki Kazuhiro-Mimaki force-pushed the Kazuhiro-Mimaki/no-array-constructor branch from 58284e7 to b733e8d Compare April 21, 2024 02:02
Copy link

codspeed-hq bot commented Apr 21, 2024

CodSpeed Performance Report

Merging #2541 will not alter performance

Comparing Kazuhiro-Mimaki:Kazuhiro-Mimaki/no-array-constructor (3b60876) with main (2db7d05)

Summary

✅ 92 untouched benchmarks

@ematipico
Copy link
Member

You'll have to run just gen-lint when you finish, there are some code gen steps to fullfil

@github-actions github-actions bot added the A-CLI Area: CLI label Apr 21, 2024
@unvalley
Copy link
Member

If you are interested, adding an action (fix suggestion) would be better.
e.g, new Array() -> []

@unvalley
Copy link
Member

unvalley commented Apr 22, 2024

@Kazuhiro-Mimaki
We made some discussion of rule naming in #2532 . useArrayLiterals is preferable. Could you rename from noArrayConstructor from useArrayLiterals? Anyway, thank you for your contribution!

@Kazuhiro-Mimaki Kazuhiro-Mimaki force-pushed the Kazuhiro-Mimaki/no-array-constructor branch from 143a6b3 to 96c6d19 Compare April 23, 2024 00:08
@github-actions github-actions bot added A-Project Area: project and removed A-Project Area: project labels Apr 23, 2024
@Kazuhiro-Mimaki Kazuhiro-Mimaki force-pushed the Kazuhiro-Mimaki/no-array-constructor branch from c991d50 to 28ca72c Compare April 23, 2024 00:31
@unvalley unvalley changed the title feat(biome_js_analyze): noArrayConstructor feat(biome_js_analyze): useArrayLiterals Apr 23, 2024
@Kazuhiro-Mimaki Kazuhiro-Mimaki force-pushed the Kazuhiro-Mimaki/no-array-constructor branch from 28ca72c to 18f5f36 Compare April 24, 2024 00:23
@unvalley
Copy link
Member

@Kazuhiro-Mimaki could you resolve conflicts? After that, we can merge this.

@Kazuhiro-Mimaki Kazuhiro-Mimaki force-pushed the Kazuhiro-Mimaki/no-array-constructor branch from 9525ec2 to 3b60876 Compare April 26, 2024 00:18
@Kazuhiro-Mimaki
Copy link
Contributor Author

Kazuhiro-Mimaki commented Apr 26, 2024

Thank you for your review. I resolved.

@unvalley unvalley merged commit ce4979d into biomejs:main Apr 26, 2024
12 checks passed
ematipico added a commit that referenced this pull request Apr 26, 2024
@Conaclos Conaclos added the A-Changelog Area: changelog label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants