feat(cli): command clean
#2528
Merged
feat(cli): command clean
#2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
feat/clean-command
branch
from
45ad820
to
fd2ca7f
Compare
arendjr
approved these changes
May 6, 2024
| /// Runs the clean command | ||
| pub fn clean(_cli_session: CliSession) -> Result<(), CliDiagnostic> { | ||
| let logs_dir = biome_log_dir(); | ||
| remove_dir_all(logs_dir.clone()).and_then(|_| create_dir(logs_dir))?; |
There was a problem hiding this comment.
Why do we immediately recreate the dir? Wouldn't it be automatically recreated the next time you run biome anyway? If so, it feels "cleaner" to just remove and leave it at that...
There was a problem hiding this comment.
If there's a Daemon running, it won't log anything anymore, and users would need to restart it manually to recreate the folder
unvalley
reviewed
May 6, 2024
Co-authored-by: unvalley <[email protected]>
unvalley
approved these changes
May 7, 2024
Conaclos
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1450
Test Plan
I tested it locally