feat(lint/noConstantCondition): allow while(true)
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
github-actions
bot
added
A-Linter
ematipico
changed the title
while(true)while(true)
ematipico
reviewed
Aug 21, 2023
|
Could you update the description of the issue, and add something about the added code action? |
Conaclos
force-pushed
the
conaclos/noConstantCondition/whileTrue
branch
2 times, most recently
from
42613ab
to
0d8fa78
Compare
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
reviewed
Aug 22, 2023
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_constant_condition.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_constant_condition.rs
Outdated
Show resolved
Hide resolved
Conaclos
force-pushed
the
conaclos/noConstantCondition/whileTrue
branch
from
0d8fa78
to
dcba347
Compare
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
force-pushed
the
conaclos/noConstantCondition/whileTrue
branch
from
dcba347
to
aa67114
Compare
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
force-pushed
the
conaclos/noConstantCondition/whileTrue
branch
from
aa67114
to
abbd3d1
Compare
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements what we discuss in rome#4746.
while (true) {}is now ignored bynoConstantCondition.Test Plan
Updated tests.