Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release_lsp): fix vscode extension build #249

Merged
merged 1 commit into from
Sep 12, 2023
Merged

ci(release_lsp): fix vscode extension build #249

merged 1 commit into from
Sep 12, 2023

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Sep 12, 2023

Summary

When creating #219, we forgot to update the release_lsp workflow to use pnpm instead of npm.

This PR should solve the issue.

  • Setup pnpm in GitHub Actions
  • Update npm with pnpm in scripts

Test Plan

  • Trigger the pipeline manually (workflow_dispatch) to ensure that it behaves as intended (@ematipico).

@ematipico
Copy link
Member

For security reasons, I can't trigger a workflow from a fork, although you can try it in your own fork :)

We just need to make sure that it builds

@ematipico ematipico merged commit 6511f5f into biomejs:main Sep 12, 2023
2 checks passed
@ematipico
Copy link
Member

Just tested it, still some issues. This time, when packaging the extension.

@nhedger
Copy link
Member Author

nhedger commented Sep 12, 2023

I've identified the issue. I'll pr something shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants