Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare knope #2484

Merged
merged 2 commits into from
Apr 17, 2024
Merged

chore: prepare knope #2484

merged 2 commits into from
Apr 17, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Apr 16, 2024

Summary

This PR does two things:

  • it creates a knope workflow to create a changeset via the script just new-changeset. It present a prompt where users need choose the packages to update
    Screenshot 2024-04-16 at 15 33 20
  • it creates a knope workflow meant to be run in CI. This workflow will create a PR that will prepare the release. If this PR is merged, then the real release will be triggered.
  • It adds a GitHub prepare_release.yml workflow that run the knope workflow prepare-release

Important

The release workflow isn't hooked with knope yet, so that PR won't do anything.

I will follow up with another PR to update our current release workflow only after we reach a stable stage where we can hold off on bug fixes.

Test Plan

@github-actions github-actions bot added the A-Tooling Area: internal tools label Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 81f673b
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661e909c2509bd0008e68e12
😎 Deploy Preview https://deploy-preview-2484--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #2484 will improve performances by 48.99%

Comparing chore/prepare-knope (81f673b) with main (895e4a9)

Summary

⚡ 2 improvements
✅ 91 untouched benchmarks

Benchmarks breakdown

Benchmark main chore/prepare-knope Change
big5-added.json[cached] 3.2 ms 2.1 ms +48.99%
big5-added.json[uncached] 3.2 ms 2.7 ms +15.86%

@ematipico ematipico merged commit 2ba517e into main Apr 17, 2024
19 checks passed
@ematipico ematipico deleted the chore/prepare-knope branch April 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant