Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up dependencies #2480

Merged
merged 1 commit into from
Apr 16, 2024
Merged

chore: tidy up dependencies #2480

merged 1 commit into from
Apr 16, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR removes a few duplicate crates around the codebase.

Also, it upgrades hashbrown to the latest, which has a breaking change. The new method extract_if doesn't Drop the elements anymore, so now the drop is implemented manually.

Test Plan

The manual drop doesn't break a test that was failing on my machine.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Tooling Area: internal tools A-Diagnostic Area: diagnostocis labels Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 3f6928e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661e283d928b78000868bef6
😎 Deploy Preview https://deploy-preview-2480--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@ematipico ematipico merged commit 7156af0 into main Apr 16, 2024
18 checks passed
@ematipico ematipico deleted the chore/tidy-up-crates branch April 16, 2024 07:52
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #2480 will improve performances by 6.67%

Comparing chore/tidy-up-crates (3f6928e) with main (d4b2d3e)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main chore/tidy-up-crates Change
db.json[uncached] 86.2 ms 80.8 ms +6.67%

@Sec-ant
Copy link
Member

Sec-ant commented Apr 17, 2024

I'm having some weird issues when running cargo build --lib --target wasm32-unknown-unknown in crates/biome_wasm.

At first it emits:

...
error: could not compile `hashbrown` (lib) due to 807 previous errors

And now it emits sth like:

...
error[E0599]: no function or associated item named `new` found for struct `IndexMap` in the current scope
...
error: could not compile `biome_js_parser` (lib) due to 4 previous errors

And sometimes it can be built successfully.

Is this related to this PR? This issue now breaks the website pnpm build:wasm or pnpm build:wasm-dev. But strange enough the build script on netlify seems working well.

Edit:

Ah, nevermind. I think this is caused by the cached target dir. It works when I delete it and rebuild everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants