feat: start working on yaml support #2428

defnot001 · 2024-04-12T19:10:24Z

Summary

first step in issue #2365

This PR has the grammar and all the required steps to get codegen to run (the generated files are also in this PT). I made this PR so other contributors don't have to do the same thing than I did.

Please leave your suggestions and opinions on the very simple grammar I did so far.

Test Plan

Currently nothing shows that my implementation is actually correct.

netlify · 2024-04-12T19:10:40Z

✅ Deploy Preview for biomejs ready!

Name	Link
🔨 Latest commit	`5cce5bf`
🔍 Latest deploy log	https://app.netlify.com/sites/biomejs/deploys/661f86eedd86e8000853e84e
😎 Deploy Preview	https://deploy-preview-2428--biomejs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 Accessibility: 97 Best Practices: 100 SEO: 93 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

xtask/codegen/src/generate_syntax_kinds.rs

xtask/codegen/src/language_kind.rs

castarco · 2024-04-12T19:21:08Z

xtask/codegen/src/yaml_kinds_src.rs

+        ("*", "ASTERISK"),
+        ("#", "HASH"),
+        ("---", "DOC_START"),
+        ("...", "DOC_END"),


Should we also add & and << here? (for "anchors": https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/)

Yea that sounds good to me, I overlooked them.

https://yaml.org/spec/1.2.2/#anchors-and-aliases searching in this file for override and << gave me no results, do you know why that is different than the atlassian site?

I'm a bit surprised, I used overrides myself when dealing with Gitlab CI configurations (so it's not only Atlassian who uses them). Looking into that now... 🤔

Surely yaml.org would keep their own spec updated right ..... right?

Oh. Interesting. See https://yaml.org/spec/1.2.2/ext/changes/ , in section "Changes in version 1.2 (revision 1.2.0) (2009-07-21)".

Okay that would mean that in our quest of supporting the latest (for now) we should leave it out. Although that immediatly makes it less useful since most people use yaml for ci and other infra stuff and there it probably still works

Seeing this, I'm not sure about the ideal approach for this. Shared grammar for both specs? and running specialized checks later at the parser & linter levels?

Probably yes since otherwise we take away most of the reason that people would use this.

codspeed-hq · 2024-04-13T06:50:34Z

CodSpeed Performance Report

Merging #2428 will not alter performance

_{Comparing defnot001:yaml (5cce5bf) with main (c9a9001)}

Summary

✅ 93 untouched benchmarks

xtask/codegen/src/language_kind.rs

crates/biome_yaml_factory/Cargo.toml

crates/biome_yaml_syntax/Cargo.toml

ematipico · 2024-04-16T08:40:19Z

@defnot001 can we make the PR ready and merge it?

It's ok if there's still nothing, but having the crates in place will unblock everyone

copy paste bad

…thing

Co-authored-by: Maikel <[email protected]>

ematipico · 2024-04-16T11:25:28Z

@defnot001 I just pushed a couple of commits to fix the CI failure. I think the PR is ready to be merged.

there is some todo!() in there

ematipico · 2024-04-16T16:26:23Z

@defnot001 I think you have to run just f and you should be good with CI

defnot001 · 2024-04-16T16:32:00Z

@defnot001 I think you have to run just f and you should be good with CI

perfect, just did that thanks :)

github-actions bot added the A-Tooling Area: internal tools label Apr 12, 2024

castarco reviewed Apr 12, 2024

View reviewed changes

xtask/codegen/src/generate_syntax_kinds.rs Outdated Show resolved Hide resolved

castarco reviewed Apr 12, 2024

View reviewed changes

xtask/codegen/src/language_kind.rs Outdated Show resolved Hide resolved

castarco reviewed Apr 12, 2024

View reviewed changes

defnot001 marked this pull request as draft April 12, 2024 19:22

Netail reviewed Apr 15, 2024

View reviewed changes

xtask/codegen/src/language_kind.rs Outdated Show resolved Hide resolved

Netail reviewed Apr 15, 2024

View reviewed changes

crates/biome_yaml_factory/Cargo.toml Show resolved Hide resolved

crates/biome_yaml_factory/Cargo.toml Outdated Show resolved Hide resolved

crates/biome_yaml_syntax/Cargo.toml Show resolved Hide resolved

crates/biome_yaml_syntax/Cargo.toml Outdated Show resolved Hide resolved

ematipico marked this pull request as ready for review April 16, 2024 08:40

defnot001 and others added 14 commits April 16, 2024 12:23

feat: start working on yaml support

d227105

fix: rename to YAML_STRING_LITERAL

90e16c3

copy paste bad

fix: use single imports only

2186b01

fix: add << and & characters to punct

1252fa8

fix: run codegen to add SHL and AMP

9ecfe15

fix: remove YAML_SCALAR from nodes since it's already in the literals

c16f4ae

fix: make ungram simpler since this language allows for basically any…

1610bb0

…thing

Update xtask/codegen/src/language_kind.rs

7766b86

Co-authored-by: Maikel <[email protected]>

Update crates/biome_yaml_syntax/Cargo.toml

58fee5b

Co-authored-by: Maikel <[email protected]>

Update crates/biome_yaml_factory/Cargo.toml

d5357a1

Co-authored-by: Maikel <[email protected]>

Update crates/biome_yaml_factory/Cargo.toml

deb0bba

Co-authored-by: Maikel <[email protected]>

Update crates/biome_yaml_syntax/Cargo.toml

fdc6297

Co-authored-by: Maikel <[email protected]>

fix workspace failure

a9ceb7b

fix format

4432d75

ematipico force-pushed the yaml branch from d50a433 to 4432d75 Compare April 16, 2024 11:24

defnot001 added 3 commits April 16, 2024 18:06

feat: handle re-exports

d47c12f

feat: impl type conversions and biome rowan syntaxkind

48bf5c6

fix: adhere to schema found in the other crates

4664f3c

defnot001 added 9 commits April 16, 2024 18:07

impl Language for Yaml and export type aliases

5a66f87

feat: organize reexports for yaml factory

70beb44

feat: add yaml related crates

10cf371

feat: start working on yaml lexer

752be8e

there is some todo!() in there

fix: apply cargo fmt

b68b3e4

feat: add cargo.toml and readme as seen in other crates

c61f27e

feat: add lexer module

35890af

fix: replace version 0.1.0 with 0.0.1

3ba4812

fix: add biome yaml parser

9f1143a

fix: run just f

e8a6085

ematipico added 2 commits April 17, 2024 09:16

fix grammar mistake

034d26e

fix clippy and format

5cce5bf

ematipico merged commit c9a9001 into biomejs:main Apr 17, 2024
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: start working on yaml support #2428

feat: start working on yaml support #2428

defnot001 commented Apr 12, 2024

netlify bot commented Apr 12, 2024 •

edited

Loading

castarco Apr 12, 2024

defnot001 Apr 12, 2024

defnot001 Apr 12, 2024

castarco Apr 12, 2024

defnot001 Apr 12, 2024

castarco Apr 12, 2024

defnot001 Apr 12, 2024

castarco Apr 12, 2024

defnot001 Apr 12, 2024

codspeed-hq bot commented Apr 13, 2024 •

edited

Loading

ematipico commented Apr 16, 2024

ematipico commented Apr 16, 2024

ematipico commented Apr 16, 2024

defnot001 commented Apr 16, 2024

feat: start working on yaml support #2428

feat: start working on yaml support #2428

Conversation

defnot001 commented Apr 12, 2024

Summary

Test Plan

netlify bot commented Apr 12, 2024 • edited Loading

✅ Deploy Preview for biomejs ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codspeed-hq bot commented Apr 13, 2024 • edited Loading

Merging #2428 will not alter performance

Summary

ematipico commented Apr 16, 2024

ematipico commented Apr 16, 2024

ematipico commented Apr 16, 2024

defnot001 commented Apr 16, 2024

netlify bot commented Apr 12, 2024 •

edited

Loading

codspeed-hq bot commented Apr 13, 2024 •

edited

Loading