-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(migrate): migrate nursery rules #2382
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
501f706
to
9e2e0d3
Compare
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
b8bc7c2
to
11944cf
Compare
11944cf
to
544b0ee
Compare
nursery_rule_member: JsonMember, | ||
/// The member of the group where the new rule should be moved | ||
nursery_group: JsonMember, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit worried about the fact that we have tightened the implementation to JSON config. For the time being it is ok and I don't see how we could solve it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't understand what you mean 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean we operate over JSON nodes, if one day we also handle YAML or TOML configurations, we will need to write a rule for every format.
Co-authored-by: Victorien Elvinger <[email protected]>
50e019a
to
6496bc2
Compare
CodSpeed Performance ReportMerging #2382 will not alter performanceComparing Summary
|
Summary
This PR adds a new analyzer to
biome_migrate
that automatically migrates nursery rules to stable groups.Test Plan
Unfortunately, we don't have new nursery rules that were promoted, so I had to come up with a solution where we use a made-up list of rules for testing purposes.
This will change once we start migrating rules.