Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(biome_deserialize): display parsing error source #2284

Merged
merged 1 commit into from
Apr 3, 2024
Merged

refactor(biome_deserialize): display parsing error source #2284

merged 1 commit into from
Apr 3, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Apr 3, 2024

Summary

Fix #1627

Test Plan

I updated the changed snapshots.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Website Area: website A-Changelog Area: changelog labels Apr 3, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 894f9ec
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/660d6314c1ceaf0009de5882
😎 Deploy Preview https://deploy-preview-2284--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Conaclos Conaclos changed the title refactor(biome_deserialize): add parse error source when deserializing refactor(biome_deserialize): display parse error source Apr 3, 2024
@Conaclos Conaclos changed the title refactor(biome_deserialize): display parse error source refactor(biome_deserialize): display parsing error source Apr 3, 2024
@Conaclos Conaclos merged commit ca3595f into main Apr 3, 2024
17 of 18 checks passed
@Conaclos Conaclos deleted the conaclos/deserialization-parse-error-source branch April 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Project Area: project A-Website Area: website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Biome should report the location of the error in an invalid configuration file
1 participant
@Conaclos