-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analyzer): noRedeclare breaks *.d.ts files #228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denbezrukov
temporarily deployed
to
Website deployment
September 10, 2023 18:18
— with
GitHub Actions
Inactive
github-actions
bot
added
A-Linter
Area: linter
L-JavaScript
Language: JavaScript and super languages
labels
Sep 10, 2023
denbezrukov
temporarily deployed
to
Website deployment
September 10, 2023 18:26
— with
GitHub Actions
Inactive
ematipico
approved these changes
Sep 10, 2023
denbezrukov
temporarily deployed
to
Website deployment
September 10, 2023 18:35
— with
GitHub Actions
Inactive
denbezrukov
force-pushed
the
fix/noRedeclare
branch
from
September 10, 2023 18:57
0f4839b
to
fddd508
Compare
denbezrukov
temporarily deployed
to
Website deployment
September 10, 2023 18:57
— with
GitHub Actions
Inactive
Conaclos
approved these changes
Sep 10, 2023
denbezrukov
force-pushed
the
fix/noRedeclare
branch
from
September 11, 2023 07:43
fddd508
to
ca1a2b3
Compare
denbezrukov
temporarily deployed
to
Website deployment
September 11, 2023 07:43
— with
GitHub Actions
Inactive
denbezrukov
force-pushed
the
fix/noRedeclare
branch
from
September 11, 2023 08:09
ca1a2b3
to
bf78b69
Compare
denbezrukov
temporarily deployed
to
Website deployment
September 11, 2023 08:09
— with
GitHub Actions
Inactive
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
🔥 Regression (25):
ts/babel
ts/microsoft
|
@denbezrukov are you sure this is the best way to fix the issue? Should we change the rule instead? Consider that we have access to the file source in the linter now, so we can check if a file is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Changelog
Area: changelog
A-Core
Area: core
A-Linter
Area: linter
A-Website
Area: website
L-JavaScript
Language: JavaScript and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #137
Test Plan
cargo test -p rome_js_analyze