Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): rename noSemicolonInJsx to noSuspiciousSemicolonInJsx #2220

Merged
merged 4 commits into from
Mar 28, 2024
Merged

fix(lint): rename noSemicolonInJsx to noSuspiciousSemicolonInJsx #2220

merged 4 commits into from
Mar 28, 2024

Conversation

fujiyamaorange
Copy link
Contributor

@fujiyamaorange fujiyamaorange commented Mar 27, 2024 •
edited by ematipico
Loading

Summary

Test Plan

N/A

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Mar 27, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2024 •
edited
Loading

✅ Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 6dd0cf3
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6604b15326673c00076fff5e
😎 Deploy Preview https://deploy-preview-2220--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 27, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2220 will not alter performance

Comparing fujiyamaorange:rename-rule (6dd0cf3) with main (b6d4c6e)

Summary

✅ 93 untouched benchmarks

@fujiyamaorange fujiyamaorange marked this pull request as ready for review March 27, 2024 01:19
@unvalley unvalley changed the title Rename noSemicolonInJsx to noSuspiciousSemicolonInJsx fix(lint): rename noSemicolonInJsx to noSuspiciousSemicolonInJsx Mar 27, 2024
@Sec-ant Sec-ant merged commit 5e219db into biomejs:main Mar 28, 2024
17 checks passed
@fujiyamaorange fujiyamaorange deleted the rename-rule branch March 28, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@Sec-ant Sec-ant Sec-ant approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💅 Rename noSemicolonInJsx rule?
3 participants
@fujiyamaorange @ematipico @Sec-ant