Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): quick fix code actions #2178

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

Sec-ant
Copy link
Member

@Sec-ant Sec-ant commented Mar 24, 2024

Summary

  • Quick fix shouldn't pull lint fix actions when the linter is disabled in the config.
  • Also fix some errors in the changelog.

Closes #2161.

Test Plan

I didn't figure out a way to add test cases for this fix. I tested it locally with the VSCode Extension and it works as expected.

@github-actions github-actions bot added A-LSP Area: language server protocol A-Website Area: website A-Changelog Area: changelog labels Mar 24, 2024
Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 1bc1d0b
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66015971df5c55000898325f
😎 Deploy Preview https://deploy-preview-2178--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sec-ant Sec-ant merged commit 5d5520a into biomejs:main Mar 25, 2024
15 of 16 checks passed
@Sec-ant Sec-ant deleted the fix/lsp-js-code-action branch March 25, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-LSP Area: language server protocol A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 VSCode ignore biome config linter.enable false
2 participants