fix(biome_fs): configuration resolution #2169
Merged
+257
−104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I refactored the
auto_search
function that is used to find the configuration file. In the previous version of this function, the searching process would immediately stop if it couldn't find abiome.json
file in the user provided base path, which isn't an expected behavior becauseconfig-path
accepts a directory path, not a file path. So it should search all the possible alternatives, i.e.biome.jsonc
file in the user provided path as well, and only returns an error if it cannot find any configuration file in that directory path.Closes #2164.
Test Plan
I added a test case to ensure that the
biome.jsonc
configuration file can now be correctly resolved in the user provided config path.