Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(biome_fs): configuration resolution #2169

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

Sec-ant
Copy link
Member

@Sec-ant Sec-ant commented Mar 23, 2024

Summary

I refactored the auto_search function that is used to find the configuration file. In the previous version of this function, the searching process would immediately stop if it couldn't find a biome.json file in the user provided base path, which isn't an expected behavior because config-path accepts a directory path, not a file path. So it should search all the possible alternatives, i.e. biome.jsonc file in the user provided path as well, and only returns an error if it cannot find any configuration file in that directory path.

Closes #2164.

Test Plan

I added a test case to ensure that the biome.jsonc configuration file can now be correctly resolved in the user provided config path.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Website Area: website A-Changelog Area: changelog labels Mar 23, 2024
Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 0389c06
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65fe78823be2b90008783cf6
😎 Deploy Preview https://deploy-preview-2169--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sec-ant Sec-ant force-pushed the fix/configuration-resolution branch from 808e38f to 0389c06 Compare March 23, 2024 06:36
@Sec-ant Sec-ant requested review from a team March 23, 2024 07:02
@Sec-ant Sec-ant merged commit 523181c into biomejs:main Mar 23, 2024
16 checks passed
@Sec-ant Sec-ant deleted the fix/configuration-resolution branch March 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--config-path fails with JSONC
2 participants