Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update links displayed in biome init, the previous were broken #213

Merged
merged 2 commits into from
Sep 9, 2023
Merged

chore: update links displayed in biome init, the previous were broken #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
febff4f
chore: update links, the previous were broken
WagnerMoreira Sep 9, 2023
ec44c70
chore: update link to the config page, the previous was broken
WagnerMoreira Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/biome_cli/src/commands/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ pub(crate) fn init(mut session: CliSession) -> Result<(), CliDiagnostic> {

"<Info><Emphasis>"Files created "</Emphasis></Info>{HorizontalLine::new(106)}"

"<Dim>"- "</Dim><Emphasis>"biome.json: "</Emphasis>"Your project configuration. Documentation: "<Hyperlink href="https://biomejs.dev/configuration">"https://biomejs.dev/configuration"</Hyperlink>"
"<Dim>"- "</Dim><Emphasis>"biome.json: "</Emphasis>"Your project configuration. Documentation: "<Hyperlink href="https://biomejs.dev/reference/configuration">"https://biomejs.dev/reference/configuration"</Hyperlink>"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link wasn't mentioned in the issue but obviously I tested everything and this one was broken too


"<Info><Emphasis>"Next Steps "</Emphasis></Info>{HorizontalLine::new(109)}"

"<Dim>"1."</Dim>" "<Emphasis>"Setup an editor extension"</Emphasis>"
Get live errors as you type and format when you save. Learn more: "<Hyperlink href="https://biomejs.dev/editors">"https://biomejs.dev/editors"</Hyperlink>"
Get live errors as you type and format when you save. Learn more: "<Hyperlink href="https://biomejs.dev/guides/getting-started#editor-setup">"https://biomejs.dev/guides/getting-started#editor-setup"</Hyperlink>"

"<Dim>"2."</Dim>" "<Emphasis>"Try a command"</Emphasis>"
"<Italic>"biome ci"</Italic>" checks for lint errors and verifies formatting. Run " <Italic>"biome --help"</Italic>" for a full list of commands and options.
Expand Down
4 changes: 2 additions & 2 deletions crates/biome_cli/tests/snapshots/main_commands_init/creates_config_file.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ Welcome to Biome! Let's get you started...

Files created ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

- biome.json: Your project configuration. Documentation: https://biomejs.dev/configuration
- biome.json: Your project configuration. Documentation: https://biomejs.dev/reference/configuration

Next Steps ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

1. Setup an editor extension
Get live errors as you type and format when you save. Learn more: https://biomejs.dev/editors
Get live errors as you type and format when you save. Learn more: https://biomejs.dev/guides/getting-started#editor-setup

2. Try a command
biome ci checks for lint errors and verifies formatting. Run biome --help for a full list of commands and options.
Expand Down
4 changes: 2 additions & 2 deletions ...shots/main_commands_init/creates_config_file_when_rome_installed_via_package_manager.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ Welcome to Biome! Let's get you started...

Files created ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

- biome.json: Your project configuration. Documentation: https://biomejs.dev/configuration
- biome.json: Your project configuration. Documentation: https://biomejs.dev/reference/configuration

Next Steps ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

1. Setup an editor extension
Get live errors as you type and format when you save. Learn more: https://biomejs.dev/editors
Get live errors as you type and format when you save. Learn more: https://biomejs.dev/guides/getting-started#editor-setup

2. Try a command
biome ci checks for lint errors and verifies formatting. Run biome --help for a full list of commands and options.
Expand Down