Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatter): indent instead of align in conditionals #2078

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

@ematipico ematipico requested review from a team March 13, 2024 10:32
@github-actions github-actions bot added A-Formatter Area: formatter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Mar 13, 2024
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 3def724
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f1a726a1419a00096a7b63
😎 Deploy Preview https://deploy-preview-2078--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico
Copy link
Member Author

Thank you, I suppose I'll have to do a check on the indentation style

Copy link

codspeed-hq bot commented Mar 13, 2024

CodSpeed Performance Report

Merging #2078 will improve performances by 33.07%

⚠️ No base runs were found

Falling back to comparing fix/mix-spaces-tabs (3def724) with main (0a74c02)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main fix/mix-spaces-tabs Change
big5-added.json[cached] 3 ms 2.2 ms +33.07%

@ematipico ematipico force-pushed the fix/mix-spaces-tabs branch from 1ba42c3 to b910b27 Compare March 13, 2024 11:48
@ematipico ematipico force-pushed the fix/mix-spaces-tabs branch from 3343383 to 7d9b9b9 Compare March 13, 2024 13:14
@ematipico ematipico merged commit 172d906 into main Mar 13, 2024
21 checks passed
@ematipico ematipico deleted the fix/mix-spaces-tabs branch March 13, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Mixed Tab/Space on ternary
3 participants