Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: language creation #2042

Merged
merged 5 commits into from
Mar 11, 2024
Merged

docs: language creation #2042

merged 5 commits into from
Mar 11, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR adds some documentation and instructions around our grammar.

It also refactors the code gen to have everything inside LanguageKind, which means that when adding a new language, the developer just need update the methods inside the impl LangaugeKind, nothing else (other then creating the KindSrc)

Test Plan

CI should pass. Proof read

@ematipico ematipico changed the title chore: language creation docs: language creation Mar 11, 2024
@github-actions github-actions bot added A-Tooling Area: internal tools A-Website Area: website labels Mar 11, 2024
@ematipico ematipico requested review from a team March 11, 2024 10:59
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 547ad8e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65eeeffa34d9960008b26099

Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! This will definitely help to smooth the process for additional languages.

xtask/codegen/README.md Outdated Show resolved Hide resolved
xtask/codegen/README.md Outdated Show resolved Hide resolved
xtask/codegen/src/language_kind.rs Outdated Show resolved Hide resolved
Co-authored-by: Arend van Beelen jr. <[email protected]>
@ematipico ematipico merged commit 2355969 into main Mar 11, 2024
13 of 20 checks passed
@ematipico ematipico deleted the chore/refactor-langauge-creation branch March 11, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants