Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix useLiteralKeys bug with empty string key #203

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

ssssota
Copy link
Contributor

@ssssota ssssota commented Sep 8, 2023

Summary

close #191

Test Plan

I added some tests and updated the snapshots for them.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 8, 2023
@Conaclos Conaclos merged commit c9c7db6 into biomejs:main Sep 9, 2023
12 checks passed
@Conaclos
Copy link
Member

Conaclos commented Sep 9, 2023

Thanks! Simple and perfect fix!

@ssssota ssssota deleted the useLiteralKeys-empty-string branch September 9, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 useLiteralKeys breaks object key
2 participants