feat(cli): add --stdio
argument to lsp-proxy
command
#1997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a bogus
--stdio
argument for thelsp-proxy
command.According to the Implementation Considerations section of the LSP specification, it is recommended that language servers support the
--stdio
argument if the server communicates over stdio.The absence of this argument actually makes it harder to spawn Biome's LSP when using
vscode-languageclient
, because it appends an--stdio
argument to the command, and since thelsp-proxy
command does not support it, the binary exits with an error.By introducing this bogus (and hidden) argument, we make it easier to interface with Biome's LSP.
Test Plan
Try spawning Biome's LSP using vscode-languageclient: