Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: foudations for migration from prettier #1545

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Conversation

ematipico
Copy link
Member

Summary

This PR sets the foundation for the future command biome migrate --prettier.

This PR creates the data structure that mimics the prettier configuration and its deserialisation, and it converts it to the Biome configuration.

Test Plan

Added a couple of tests. CI should pass

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 464f8b1
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a256ac6c604800089883f5
😎 Deploy Preview https://deploy-preview-1545--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico ematipico requested review from a team January 12, 2024 18:15
@github-actions github-actions bot added A-CLI Area: CLI A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Jan 12, 2024
Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #1545 will degrade performances by 38.32%

⚠️ No base runs were found

Falling back to comparing feat/migrate-prettier (464f8b1) with main (cf3434c)

Summary

⚡ 1 improvements
❌ 2 (👁 2) regressions
✅ 90 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/migrate-prettier Change
👁 big5-added.json[uncached] 2.9 ms 4.6 ms -38.32%
👁 eucjp.json[cached] 4.3 ms 4.7 ms -9.23%
db.json[cached] 76.4 ms 71.7 ms +6.51%

@ematipico ematipico merged commit 029ec57 into main Jan 13, 2024
20 checks passed
@ematipico ematipico deleted the feat/migrate-prettier branch January 13, 2024 10:42
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 22, 2024
ematipico added a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants