Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): add git-hook Japanese translation #1503

Merged
merged 22 commits into from
Jan 11, 2024

Conversation

OldBigBuddha
Copy link
Contributor

Summary

Translate git-hooks into Japanese

related to #1421

Test Plan

N/A

@OldBigBuddha OldBigBuddha requested a review from a team as a code owner January 10, 2024 08:04
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit b191d31
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a0141a9f4eff0007bb9dca
😎 Deploy Preview https://deploy-preview-1503--biomejs.netlify.app/ja/recipes/git-hooks
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the A-Website Area: website label Jan 10, 2024
@ematipico
Copy link
Member

cc @biomejs/japanese-translation-reviewers , could you please review it?

@unvalley
Copy link
Member

Okay, I'll check

Comment on lines +22 to +28
```yaml title="lefthook.yml"
pre-commit:
commands:
check:
glob: "*.{js,ts,cjs,mjs,d.cts,d.mts,jsx,tsx,json,jsonc}"
run: npx biome check --no-errors-on-unmatched --files-ignore-unknown=true {staged_files}
```
Copy link
Member

@unvalley unvalley Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code block is broken. The original does too, so we need to fix it.

It looks like:
Screenshot 2024-01-11 at 0 00 01

Copy link
Member

@unvalley unvalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution! I left some minor suggestions.

website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/recipes/git-hooks.mdx Outdated Show resolved Hide resolved
Copy link
Member

@unvalley unvalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution! I left some minor suggestions.
If my suggestions are valid, please commit changes by commit suggestion.

@unvalley unvalley changed the title doc: add git-hook Japanese translation docs(website): add git-hook Japanese translation Jan 10, 2024
OldBigBuddha and others added 17 commits January 12, 2024 00:52
@OldBigBuddha
Copy link
Contributor Author

@unvalley I appreciate your reviews. I applied all your suggestions!
Please check it again 🙏

@unvalley
Copy link
Member

@OldBigBuddha Thank you, looks good to me!

@unvalley unvalley merged commit e8d4335 into biomejs:main Jan 11, 2024
8 checks passed
@OldBigBuddha OldBigBuddha deleted the docs/translate-git-hooks-into-ja branch January 12, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants