Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deserialize): allow setting name for root deserialized value #1463

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jan 8, 2024

Summary

Allow naming the root deserialized value.
This addresses some requests of #1250.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 2257da3
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/659bf9d8346365000872a721

@github-actions github-actions bot added A-Project Area: project A-Parser Area: parser A-Tooling Area: internal tools L-JSON Language: JSON and super languages labels Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

@Conaclos Conaclos force-pushed the conaclos/deserialize/named-root branch 2 times, most recently from 6d380c4 to ca0b24d Compare January 8, 2024 12:23
@github-actions github-actions bot added L-CSS Language: CSS and removed A-Tooling Area: internal tools labels Jan 8, 2024
@Conaclos Conaclos force-pushed the conaclos/deserialize/named-root branch from ca0b24d to aaad110 Compare January 8, 2024 12:27
Copy link

codspeed-hq bot commented Jan 8, 2024

CodSpeed Performance Report

Merging #1463 will degrade performances by 15.87%

Comparing conaclos/deserialize/named-root (aaad110) with main (cc3a756)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/deserialize/named-root Change
eucjp.json[uncached] 5.1 ms 6.1 ms -15.87%

@Conaclos Conaclos force-pushed the conaclos/deserialize/named-root branch from aaad110 to b7c45e1 Compare January 8, 2024 12:51
@github-actions github-actions bot removed the A-Parser Area: parser label Jan 8, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where we use this new field?

@Conaclos
Copy link
Member Author

Conaclos commented Jan 8, 2024

Can we add a test where we use this new field?

You mean in the doctest?

@Conaclos Conaclos force-pushed the conaclos/deserialize/named-root branch from b7c45e1 to fc6b8dd Compare January 8, 2024 13:20
@github-actions github-actions bot removed the L-CSS Language: CSS label Jan 8, 2024
@Conaclos Conaclos force-pushed the conaclos/deserialize/named-root branch 3 times, most recently from e744f99 to 2257da3 Compare January 8, 2024 13:34
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you!

@ematipico ematipico changed the title refactor(deserialize): allow setting name for root deserialized value refactor(deserialiaze): allow setting name for root deserialized value Jan 8, 2024
@ematipico ematipico changed the title refactor(deserialiaze): allow setting name for root deserialized value refactor(deserialize): allow setting name for root deserialized value Jan 8, 2024
@ematipico ematipico merged commit d9da366 into main Jan 8, 2024
18 checks passed
@ematipico ematipico deleted the conaclos/deserialize/named-root branch January 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants