Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refcator(lint/noInvalidUseBeforeDeclaration): allow use before as a type #1461

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jan 7, 2024

Summary

Allow use-before declarations when the variable is used as a type.
This removes many false positives.

Test Plan

New test included.

Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit ae29e85
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/659b342abfc8df0008cbef5f

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 7, 2024
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 7, 2024
@Conaclos Conaclos force-pushed the conaclos/lint/noInvalidUseBeforeDeclaration/allow-use-before-as-a-type branch from 1061880 to ae29e85 Compare January 7, 2024 23:30
@github-actions github-actions bot removed the A-Changelog Area: changelog label Jan 7, 2024
@Conaclos Conaclos merged commit 8ce8f4e into main Jan 7, 2024
16 of 17 checks passed
@Conaclos Conaclos deleted the conaclos/lint/noInvalidUseBeforeDeclaration/allow-use-before-as-a-type branch January 7, 2024 23:31
Copy link

codspeed-hq bot commented Jan 7, 2024

CodSpeed Performance Report

Merging #1461 will not alter performance

Comparing conaclos/lint/noInvalidUseBeforeDeclaration/allow-use-before-as-a-type (ae29e85) with main (8e3d3e2)

Summary

✅ 93 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant