Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_formatter): fix invalid formatting of expanded bindings for AsNeeded arrow parens #1449

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

faultyserver
Copy link
Contributor

Summary

Fixes #1106. Fixes #1428.

Test Plan

Added two spec tests to cover the cases given in the issue reports.

Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit a4af9e3
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6598dba3608d660008603347
😎 Deploy Preview https://deploy-preview-1449--biomejs.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Jan 6, 2024
Copy link

codspeed-hq bot commented Jan 6, 2024

CodSpeed Performance Report

Merging #1449 will degrade performances by 6.74%

Comparing faulty/js-fix-asneeded (a4af9e3) with main (86688e4)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main faulty/js-fix-asneeded Change
big5-added.json[cached] 2.3 ms 2.4 ms -6.74%

@faultyserver faultyserver merged commit 01ada2e into main Jan 6, 2024
21 of 22 checks passed
@faultyserver faultyserver deleted the faulty/js-fix-asneeded branch January 6, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
1 participant