Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css_formatter): formatting support for supports at-rules #1348

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

faultyserver
Copy link
Contributor

Summary

#1285. Support for @supports! These rules are also very similar to media query and container query lists. I'm not sure if there's a great way to genericize the formatting for them, since they all need independent nodes for the syntax tree, but the formatting structure is very similar (group, soft block indent, and/not/or conditions, etc.).

Test Plan

Copied over the parser spec tests with whitespace changes to cover all of the various permutations. This test suite again shows the need for a mechanism to lowercase keywords.

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 33b7a17
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/658b4e6f18947100082bf9ab

@github-actions github-actions bot added A-Formatter Area: formatter L-CSS Language: CSS labels Dec 26, 2023
@faultyserver faultyserver merged commit 5ae49cd into main Dec 26, 2023
18 checks passed
@faultyserver faultyserver deleted the faulty/css-supports branch December 26, 2023 22:29
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants