Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): keep parent configuration when computing overrides #1278

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Dec 21, 2023

Summary

Closes #691
Closes #1190

The issue was that when we were computing the overrides of the formatter and the linter, we were silently applying Biome's defaults.

This PR fixes the issue by using the parent configuration before applying the default.

Test Plan

I added new test cases

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit cef1c59
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/658431edd1205600088c65eb
😎 Deploy Preview https://deploy-preview-1278--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project labels Dec 21, 2023
@github-actions github-actions bot added A-Website Area: website A-Changelog Area: changelog labels Dec 21, 2023
@ematipico ematipico merged commit 4eab98a into main Dec 22, 2023
20 checks passed
@ematipico ematipico deleted the fix/overrides-should-keep-configured-settings branch December 22, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Project Area: project A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Overriding javascript globals overrides formatter defaults 🐛 Unexpected override behavior
1 participant