Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): add missing indentwidth for js in config reference #1073

Merged
merged 1 commit into from
Dec 6, 2023
Merged

docs(website): add missing indentwidth for js in config reference #1073

merged 1 commit into from
Dec 6, 2023

Conversation

thunfisch987
Copy link
Contributor

@thunfisch987 thunfisch987 commented Dec 6, 2023

Summary

You get a warning when using javascript.formatter.indentSize because it's been replaced by indentwidth.
The config reference for the global formatter settings has indentSize and indentWidth but indentWidth is currently missing from the javascript section (see here).

closes #1072

Test Plan

  • running the dev server and checking if the option is there

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit b0d11a5
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/656fc5037cf90e0007924255
😎 Deploy Preview https://deploy-preview-1073--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the A-Website Area: website label Dec 6, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ematipico ematipico merged commit b237ffe into biomejs:main Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Docs] config reference is missing javascript.formatter.indentWidth
2 participants